feat: add experimental transaction support#310
Open
pepicrft wants to merge 3 commits intoplausible:masterfrom
Open
feat: add experimental transaction support#310pepicrft wants to merge 3 commits intoplausible:masterfrom
pepicrft wants to merge 3 commits intoplausible:masterfrom
Conversation
pepicrft
force-pushed
the
codex/experimental-transactions
branch
from
1781793 to
0acf8c2
Compare
ruslandoga
force-pushed
the
master
branch
2 times, most recently
from
e19f920 to
8ffff4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related plausible/ecto_ch#268
We'd like to start using transactional Ecto tests, and for that, we need this library to have support for transactions. This PR addresses that, adding a transaction state that's persisted across the operations.
Summary
faults_test.exsinto a parsed request helper and generic response builderWhy
This makes it possible to experiment with Ecto SQL sandbox support on top of ClickHouses experimental transaction feature while keeping the driver tests readable and focused.
Validation
mix test test/ch/faults_test.exs test/ch/connection_test.exs